Be permissive about tiff axis metadata #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
+ Coverage 89.76% 90.53% +0.77%
==========================================
Files 35 35
Lines 1427 1427
==========================================
+ Hits 1281 1292 +11
+ Misses 146 135 -11 ☔ View full report in Codecov by Sentry. |
adamltyson
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
Current code loading tiff z stacks into memory throws an error, but...
read_z_stackandget_size_image_from_file_pathsfunctions?What does this PR do?
Follow-up to #73
Modifies
read_z_stackto write debug logs instead of throwing an error, if a tiff stack with no axis metadata is read.Adds tests that check that debug log is called in these cases.
References
PR discussion linked above
How has this PR been tested?
New tests added.
Is this a breaking change?
No.
Does this PR require an update to the documentation?
If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.
Checklist: